linux-kernel - Re: [PATCH 17/37] x86, pkeys: add functions to fetch PKRU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <565C7094.8070706@sr71.net>
Date:	Mon, 30 Nov 2015 07:51:48 -0800
From:	Dave Hansen <dave@...1.net>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	dave.hansen@...ux.intel.com
Subject: Re: [PATCH 17/37] x86, pkeys: add functions to fetch PKRU

On 11/27/2015 01:51 AM, Thomas Gleixner wrote:
> On Mon, 16 Nov 2015, Dave Hansen wrote:
>> +#ifdef CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
>> +static inline u32 __read_pkru(void)
>> +{
>> +	unsigned int eax, edx;
>> +	unsigned int ecx = 0;
>> +	unsigned int pkru;
>> +
>> +	asm volatile(".byte 0x0f,0x01,0xee\n\t"
>> +		     : "=a" (eax), "=d" (edx)
>> +		     : "c" (ecx));
>> +	pkru = eax;
>> +	return pkru;
> 
> Wouldn't a simple 'return eax;' be sufficient?

Yes.  I wanted to make it clear that EAX specifically was where the data
we want was ending up.  But, I guess the "=a" does that equally well.

I'll fix it up.

Also, looking at this, it also deserves a mention that this is the
"rdpkru" instruction.  Otherwise, it's hard to figure out what
instruction this is.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/