[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151130161705.GY1929@sirena.org.uk>
Date: Mon, 30 Nov 2015 16:17:05 +0000
From: Mark Brown <broonie@...nel.org>
To: Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Chen-Yu Tsai <wens@...e.org>,
alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: sun4i: Implement MIC1 capture
On Mon, Nov 30, 2015 at 04:37:47PM +0100, Maxime Ripard wrote:
A couple of minor issues below but I'll apply this - please send
followup patches.
> +static void sun4i_codec_start_capture(struct sun4i_codec *scodec)
> +{
> + /*
> + * FIXME: according to the BSP, we might need to drive a PA
> + * GPIO high here on some boards
> + */
That's not something this driver needs to worry about, that's something
the machine driver will do - the whole purpose is to glue all the
different components on the board together.
> + if (clk_set_rate(scodec->clk_module, clk_freq))
> + return -EINVAL;
It'd be better to pass back the error code from clk_set_rate().
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists