linux-kernel - Re: [PATCH] ASoC: rsnd: fix a possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151130163856.GC1929@sirena.org.uk>
Date:	Mon, 30 Nov 2015 16:38:56 +0000
From:	Mark Brown <broonie@...nel.org>
To:	LABBE Corentin <clabbe.montjoie@...il.com>
Cc:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	alsa-devel@...a-project.org, lgirdwood@...il.com, perex@...ex.cz,
	tiwai@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: rsnd: fix a possible NULL dereference

On Thu, Nov 26, 2015 at 08:17:15AM +0100, LABBE Corentin wrote:
> On Wed, Nov 25, 2015 at 11:46:45PM +0000, Kuninori Morimoto wrote:

> > > +	of_data = of_device_get_match_data(dev);
> > > +	if (!of_data)
> > > +		return 1;

> > return 1 ?
> > You want to use -EINVAL ?

> I do that Uwe Kleine-König said to me to do in others thread:
> https://lkml.org/lkml/2015/11/12/70 and https://lkml.org/lkml/2015/11/16/211

What error code to return is going to depend on the context - you need
to look at what the caller is expecting and how it will handle the value
returned.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)