linux-kernel - Re: [PATCH] bugfix oom kill init lead panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151129190802.dc66cf35.akpm@linux-foundation.org>
Date:	Sun, 29 Nov 2015 19:08:02 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	<chenjie6@...wei.com>
Cc:	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	<David.Woodhouse@...el.com>, <zhihui.gao@...wei.com>,
	<lizefan@...wei.com>, <stable@...r.kernel.org>
Subject: Re: [PATCH] bugfix oom kill init lead panic

On Mon, 30 Nov 2015 18:54:29 +0800 <chenjie6@...wei.com> wrote:

> From: chenjie <chenjie6@...wei.com>
> 
> when oom happened we can see:
> Out of memory: Kill process 9134 (init) score 3 or sacrifice child                  
> Killed process 9134 (init) total-vm:1868kB, anon-rss:84kB, file-rss:572kB
> Kill process 1 (init) sharing same memory
> ...
> Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009
> 
> That's because:
> 	the busybox init will vfork a process,oom_kill_process found
> the init not the children,their mm is the same when vfork.
> 
> ...
>
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -513,7 +513,7 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
>  	rcu_read_lock();
>  	for_each_process(p)
>  		if (p->mm == mm && !same_thread_group(p, victim) &&
> -		    !(p->flags & PF_KTHREAD)) {
> +		    !(p->flags & PF_KTHREAD) && !is_global_init(p)) {
>  			if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
>  				continue;

What kernel version are you using?

I don't think this can happen in current code...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/