linux-kernel - Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151130193216.GI11298@codeaurora.org>
Date:	Mon, 30 Nov 2015 11:32:16 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	Mike Turquette <mturquette@...libre.com>,
	Chen-Yu Tsai <wens@...e.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: sunxi: pll2: Fix clock running too fast

On 11/30, Maxime Ripard wrote:
> @@ -191,25 +186,17 @@ err_unmap:
>  	iounmap(reg);
>  }
>  
> -static struct sun4i_pll2_data sun4i_a10_pll2_data = {
> -	.pre_div_flags	= CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO,
> -};
> -
>  static void __init sun4i_a10_pll2_setup(struct device_node *node)
>  {
> -	sun4i_pll2_setup(node, &sun4i_a10_pll2_data);
> +	sun4i_pll2_setup(node, &sun4i_a10_pll2_data, 0);

And it doesn't compile, because we just deleted the data that
this is taking an address of. Hmph.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/