linux-kernel - Re: [PATCH] spi/nor: Fix error message with unrecognized JEDEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPybu_19xK6Afq1j0NFT8EPRv448v3Xd-m5m-SAjKuugg-RTZQ@mail.gmail.com>
Date:	Mon, 30 Nov 2015 20:41:44 +0100
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Marek Vasut <marex@...x.de>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	Rafał Miłecki <zajec5@...il.com>,
	Huang Shijie <shijie.huang@...el.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Gabor Juhos <juhosg@...nwrt.org>,
	Bean Huo 霍斌斌 (beanhuo) 
	<beanhuo@...ron.com>, Furquan Shaikh <furquan@...gle.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi/nor: Fix error message with unrecognized JEDEC

Hello Marek

On Mon, Nov 30, 2015 at 5:46 PM, Marek Vasut <marex@...x.de> wrote:
> On Monday, November 30, 2015 at 04:25:11 PM, Ricardo Ribalda Delgado wrote:
>> The error message was:
>>
>> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00,  0,  0
>>
>> The new error message:
>>
>> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
>>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
>> ---
>>  drivers/mtd/spi-nor/spi-nor.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index b7c038c75684..7d2b96d5f350 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct
>> spi_nor *nor) return &spi_nor_ids[tmp];
>>               }
>>       }
>> -     dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
>> +     dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n",
>
> You can change it to %02x to make it consistent, no ? What do you think ?

Sure, no problem, it is just that I am more used to %.2 than %02 :)


>
>>               id[0], id[1], id[2]);
>>       return ERR_PTR(-ENODEV);
>>  }
>
> Best regards,
> Marek Vasut



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/