linux-kernel - Re: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151130.145057.216796732457000987.davem@davemloft.net>
Date:	Mon, 30 Nov 2015 14:50:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	salil.mehta@...wei.com
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	paul.gortmaker@...driver.com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, catalin.marinas@....com, will.deacon@....com,
	arnd@...db.de, liguozhu@...ilicon.com, yisen.zhuang@...wei.com,
	dingtianhong@...wei.com, zhangfei.gao@...aro.org,
	huangdaode@...ilicon.com, kenneth-lee-2012@...mail.com,
	mehta.salil.lnk@...il.com, xuwei5@...ilicon.com,
	lisheng011@...wei.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, linuxarm@...wei.com, yankejian@...wei.com,
	lipeng321@...wei.com, fengguang.wu@...el.com
Subject: Re: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to
 the Hislicon Network Subsystem

From: Salil Mehta <salil.mehta@...wei.com>
Date: Thu, 26 Nov 2015 07:14:06 +0000

> -#define ENABLE		(0x1)
> -#define DISABLE		(0x0)
> +#define ENABLE		0x1
> +#define DISABLE		0x0

Defining such common macros names for such incredibly simple boolean values
is asking for trouble, in particular it can possibly collide with other
defines in the global namespace.

Use "true", "false", and the "bool" type, because that is exactly how you
are using these values.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/