linux-kernel - Re: [PATCH 03/14] DEVICETREE: Add PIC32 clock binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Nov 2015 15:43:44 -0600
From:	Rob Herring <robh@...nel.org>
To:	Joshua Henderson <joshua.henderson@...rochip.com>
Cc:	linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
	Purna Chandra Mandal <purna.mandal@...rochip.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH 03/14] DEVICETREE: Add PIC32 clock binding documentation

On Wed, Nov 25, 2015 at 10:36:55PM -0700, Joshua Henderson wrote:
> Hi Rob,
> 
> On 11/22/2015 2:31 PM, Rob Herring wrote:
> > On Fri, Nov 20, 2015 at 05:17:15PM -0700, Joshua Henderson wrote:
> >> From: Purna Chandra Mandal <purna.mandal@...rochip.com>
> >>
> >> Document the devicetree bindings for the clock driver found on Microchip
> >> PIC32 class devices.
> >>
> >> Signed-off-by: Purna Chandra Mandal <purna.mandal@...rochip.com>
> >> Signed-off-by: Joshua Henderson <joshua.henderson@...rochip.com>
> >> ---
> >>  .../devicetree/bindings/clock/microchip,pic32.txt  |  263 ++++++++++++++++++++
> >>  1 file changed, 263 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/clock/microchip,pic32.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/clock/microchip,pic32.txt b/Documentation/devicetree/bindings/clock/microchip,pic32.txt
> >> new file mode 100644
> >> index 0000000..4cef72d
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/clock/microchip,pic32.txt
> >> @@ -0,0 +1,263 @@
> >> +Binding for a Clock hardware block found on
> >> +certain Microchip PIC32 MCU devices.
> >> +
> >> +Microchip SoC clocks-node consists of few oscillators, PLL, multiplexer
> >> +and few divider nodes.
> > 
> > [...]
> > 
> >> +Required properties:
> >> +- compatible : should have "microchip,pic32-clk".

BTW, this should list out the actual compatible strings.

> > There is some discussion about this upstream with "critical-clocks" 
> > binding. Can you use and wait for that?
> > 
> 
> The way this is going, we might not have to wait. :)  Is there a patch available yet to try it out?  

Yes, googling "Lee Jones critical-clocks" should find it.

> >> +- microchip,status-bit-mask: bitmask for status check. This will be used to confirm
> >> +    particular operation by clock sub-node is completed. It is dependent sub-node.
> >> +- microchip,bit-mask: enable mask, similar to microchip,status-bit-mask.
> > 
> > We've generally decided not to describe clocks at this level of detail 
> > in DT. It's fine though for simple clock trees. This one seems to be 
> > borderline IMO.
> > 
> 
> The binding example is the entire clock tree.  These masks are right from the datasheet.  For reference, do you have an example of a better alternative?

Okay, like I said, borderline. If this is complete, then it is fine. 
Adding more clocks or a newer version of the SoC with more clocks would 
change that opinion.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/