lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Nov 2015 17:53:18 -0500 From: Tejun Heo <tj@...nel.org> To: "Serge E. Hallyn" <serge.hallyn@...ntu.com> Cc: serge@...lyn.com, linux-kernel@...r.kernel.org, adityakali@...gle.com, linux-api@...r.kernel.org, containers@...ts.linux-foundation.org, cgroups@...r.kernel.org, lxc-devel@...ts.linuxcontainers.org, akpm@...ux-foundation.org, ebiederm@...ssion.com Subject: Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path Hello, Serge. On Mon, Nov 30, 2015 at 12:37:58PM -0600, Serge E. Hallyn wrote: > > Yeah, I agree but the name is kinda misleading tho. The output isn't > > really a relative path but rather absolute path against the specified > > root. Maybe updating the function and parameter names would be > > helpful? > > > > Ok - updating the comment is simple enough. Though the name/params > kernfs_path_from_node_locked(from, to) still seem to make sense. Would > you prefer something like kernfs_absolute_path_from node_locked()? I > hesitate to call 'from' 'root' since kernfs_root is a thing and this > is not that. Hmmm... I see. Let's just make sure that the comment is clear about the fact that it calculates (pseudo) absolute path rather than relative path. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists