linux-kernel - Re: [PATCH] net: add support for netdev notifier error injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyjONtF9r=Ox1-mMS-vzxp2j-fk+VX1wWWVvWvyOxWPbiQ@mail.gmail.com>
Date:	Tue, 1 Dec 2015 08:48:30 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Nikolay Aleksandrov <razor@...ckwall.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, shm@...ulusnetworks.com,
	gospo@...ulusnetworks.com, roopa@...ulusnetworks.com,
	dsa@...ulusnetworks.com,
	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: add support for netdev notifier error injection

2015-11-28 21:45 GMT+09:00 Nikolay Aleksandrov <razor@...ckwall.org>:
> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
>
> This module allows to insert errors in some of netdevice's notifier
> events. All network drivers use these notifiers to signal various events
> and to check if they are allowed, e.g. PRECHANGEMTU and CHANGEMTU
> afterwards. Until recently I had to run failure tests by injecting
> a custom module, but now this infrastructure makes it trivial to test
> these failure paths. Some of the recent bugs I fixed were found using
> this module.
> Here's an example:
>  $ cd /sys/kernel/debug/notifier-error-inject/netdev
>  $ echo -22 > actions/NETDEV_CHANGEMTU/error
>  $ ip link set eth0 mtu 1024
>  RTNETLINK answers: Invalid argument

This patch looks good to me.  It would be nice if you add tools like
tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh for this feature.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/