linux-kernel - Re: [PATCH 2/5] ARM: hisi: enable Hi3519 soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <565D0C44.6010502@huawei.com>
Date:	Tue, 1 Dec 2015 10:56:04 +0800
From:	xuejiancheng <xuejiancheng@...wei.com>
To:	Kevin Hilman <khilman@...nel.org>
CC:	<linux@....linux.org.uk>, <arnd@...db.de>, <olof@...om.net>,
	<xuwei5@...ilicon.com>, <haojian.zhuang@...aro.org>,
	<zhangfei.gao@...aro.org>, <bintian.wang@...wei.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
	<yanhaifeng@...ilicon.com>, <yanghongwei@...ilicon.com>,
	<suwenping@...ilicon.com>, <ml.yang@...ilicon.com>
Subject: Re: [PATCH 2/5] ARM: hisi: enable Hi3519 soc

Hi Kevin,
   Thank you for your suggestions.

On 2015/12/1 8:02, Kevin Hilman wrote:
> Jiancheng Xue <xuejiancheng@...wei.com> writes:
> 
>> Hi3519 SOC is mainly used for ip camera and sport dv
>> solutions.
>>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@...wei.com>
>> ---
>>  arch/arm/mach-hisi/Kconfig     | 9 +++++++++
>>  arch/arm/mach-hisi/hisilicon.c | 9 +++++++++
>>  2 files changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
>> index 83061ad..6bb822c 100644
>> --- a/arch/arm/mach-hisi/Kconfig
>> +++ b/arch/arm/mach-hisi/Kconfig
>> @@ -48,6 +48,15 @@ config ARCH_HIX5HD2
>>  	select PINCTRL_SINGLE
>>  	help
>>  	  Support for Hisilicon HIX5HD2 SoC family
>> +
>> +config ARCH_HI3519
> 
> Please keep these sorted alphabetically.

Sorry about that. I will correct it in next version.

> 
> Speaking of which, there is already an existing ARCH_HI3xxx entry.
> Should this be included in that family?   If not, maybe the HI3xxx
> should be renamed HI36xx ?

ARCH_HI3xxx just represents Hi36xx mobile soc family. Hi3519 is not included.
It's good advice to rename HI3xxx to HI36xx.

> Kevin
> 
> .
> 

Many thanks,

Jiacheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/