linux-kernel - Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151201004312.GA2064@katana>
Date:	Tue, 1 Dec 2015 01:43:12 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	"Yu, Xiangliang" <Xiangliang.Yu@....com>
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"andriy.shevchenko@...ux.intel.com" 
	<andriy.shevchenko@...ux.intel.com>,
	"jarkko.nikula@...ux.intel.com" <jarkko.nikula@...ux.intel.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Xue, Ken" <Ken.Xue@....com>, "Wan, Vincent" <Vincent.Wan@....com>,
	"Huang, Ray" <Ray.Huang@....com>,
	"Wang, Annie" <Annie.Wang@....com>, "Li, Tony" <Tony.Li@....com>
Subject: Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD
 controller


> > > > The driver disables TX interrupt when it is not needed anymore or
> > > > when TX gets aborted but the above will re-enable all interrupts
> > regardless.
> > > > Is that the intention?
> > > No, i2c controller can trigger next interrupt only after re-enable all interrupt.
> > 
> > If you get an error the function masks all interrupts and jumps to tx_aborted
> > label. With this patch you unmask all interrupts again before exiting the
> > function.
> > 
> 
> I see, how about change if statement to else if?

That sounds to me that a V2 is needed, or? Marking as "Changes
requested"...


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)