linux-kernel - Re: [PATCH 2/3] ACPI: scan add call to probe amba devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151201121627.GA4036@xora-haswell.xora.org.uk>
Date:	Tue, 1 Dec 2015 12:16:51 +0000
From:	Graeme Gregory <gg@...mlogic.co.uk>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Graeme Gregory <graeme.gregory@...aro.org>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, shannon.zhao@...aro.org,
	Len Brown <lenb@...nel.org>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH 2/3] ACPI: scan add call to probe amba devices

On Tue, Dec 01, 2015 at 03:16:53AM +0100, Rafael J. Wysocki wrote:
> On Wednesday, September 30, 2015 11:38:49 AM Graeme Gregory wrote:
> > Call the amba device creation function in the default enumeration path,
> > this is the same location platform devices are probed.
> 
> First, I'm sorry for the glacially slow response here.
> 
> > Cc: Rafael J. Wysocki <rjw@...ysocki.net>
> > Cc: Len Brown <lenb@...nel.org>
> > Cc: Russell King <linux@....linux.org.uk>
> > Signed-off-by: Graeme Gregory <graeme.gregory@...aro.org>
> > ---
> >  drivers/acpi/scan.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> > index f834b8c..aa3184e 100644
> > --- a/drivers/acpi/scan.c
> > +++ b/drivers/acpi/scan.c
> > @@ -1633,8 +1633,10 @@ static void acpi_default_enumeration(struct acpi_device *device)
> >  	acpi_dev_get_resources(device, &resource_list, acpi_check_spi_i2c_slave,
> >  			       &is_spi_i2c_slave);
> >  	acpi_dev_free_resource_list(&resource_list);
> > -	if (!is_spi_i2c_slave)
> > +	if (!is_spi_i2c_slave) {
> > +		acpi_create_amba_device(device);
> 
> Do you really have to add this here?
> 
> It would be much cleaner to use a new scan handler instead.
> 

I can certainly look into doing that, I cannot from a quick scan see any
reason not too. I just didn't think of it.

Graeme

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/