linux-kernel - Re: [PATCHv2] arm: Update all mm structures with section adjustments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jK-b_x5e5Qfm_A8i-k3QpjYXv=nQCXeFQknLt=x=+Mn+Q@mail.gmail.com>
Date:	Mon, 30 Nov 2015 17:10:07 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Laura Abbott <labbott@...hat.com>
Cc:	Laura Abbott <labbott@...oraproject.org>,
	Russell King <linux@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux-MM <linux-mm@...ck.org>
Subject: Re: [PATCHv2] arm: Update all mm structures with section adjustments

On Mon, Nov 30, 2015 at 4:42 PM, Laura Abbott <labbott@...hat.com> wrote:
> On 11/30/2015 03:40 PM, Kees Cook wrote:
>>
>> On Thu, Nov 19, 2015 at 11:10 AM, Kees Cook <keescook@...omium.org> wrote:
>>>
>>> On Wed, Nov 18, 2015 at 4:14 PM, Laura Abbott <labbott@...oraproject.org>
>>> wrote:
>>>>
>>>> Currently, when updating section permissions to mark areas RO
>>>> or NX, the only mm updated is current->mm. This is working off
>>>> the assumption that there are no additional mm structures at
>>>> the time. This may not always hold true. (Example: calling
>>>> modprobe early will trigger a fork/exec). Ensure all mm structres
>>>> get updated with the new section information.
>>>>
>>>> Signed-off-by: Laura Abbott <labbott@...oraproject.org>
>>>
>>>
>>> This looks right to me. :)
>>>
>>> Reviewed-by: Kees Cook <keescook@...omium.org>
>>>
>>> Russell, does this work for you?
>>
>>
>> Did this end up in the patch tracker? (I just sent a patch that'll
>> collide with this... I'm happy to do the fix up.)
>>
>
> I put this in the patch tracker this morning.

Ah-ha, great! I will rebase my change on to it and send a v2
(potentially with additional changes).

-Kees

>
>>
>> -Kees
>>
>
> Thanks,
> Laura



-- 
Kees Cook
Chrome OS & Brillo Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/