linux-kernel - Re: [PATCH 2/2] x86, perf: Use INST_RETIRED.PREC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151201145414.GE3528@tassilo.jf.intel.com>
Date:	Tue, 1 Dec 2015 06:54:14 -0800
From:	Andi Kleen <ak@...ux.intel.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	mingo@...nel.org
Subject: Re: [PATCH 2/2] x86, perf: Use INST_RETIRED.PREC_DIST for cycles:ppp

On Tue, Dec 01, 2015 at 02:41:51PM +0100, Peter Zijlstra wrote:
> On Mon, Nov 30, 2015 at 04:28:09PM -0800, Andi Kleen wrote:
> > diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c
> > index 9dfbba5..ba41899 100644
> > --- a/arch/x86/kernel/cpu/perf_event.c
> > +++ b/arch/x86/kernel/cpu/perf_event.c
> > @@ -482,6 +482,9 @@ int x86_pmu_hw_config(struct perf_event *event)
> >  			/* Support for IP fixup */
> >  			if (x86_pmu.lbr_nr || x86_pmu.intel_cap.pebs_format >= 2)
> >  				precise++;
> > +
> > +			if (x86_pmu.pebs_aliases)
> > +				precise++;
> 
> This is not accurate, it would allow :ppp for core2 for example, which
> does not at all support PREC_DIST events.
> 
> Something like so on top?

Yes that's fine. Thanks.

Are you just applying it with that change, or should I resend a combined patch?

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/