linux-kernel - Re: [PATCH 02/10] ASoC: samsung/smartq: use dynamic registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1538856.GqqaeJI10z@wuerfel>
Date:	Tue, 01 Dec 2015 16:11:40 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Kukjin Kim <kgene@...nel.org>, Mark Brown <broonie@...nel.org>,
	Vasily Khoruzhick <anarsoul@...il.com>,
	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
	Tomasz Figa <tfiga@...omium.org>,
	Ben Dooks <ben.dooks@...ethink.co.uk>,
	linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 02/10] ASoC: samsung/smartq: use dynamic registration

On Tuesday 01 December 2015 09:24:24 Krzysztof Kozlowski wrote:
> > +static struct platform_driver smartq_driver = {
> > +     .driver = {
> > +             .name = "smartq-audio",
> > +             .owner = THIS_MODULE,
> 
> The owner should not be needed (coccicheck should also complain). Rest
> looks good, so:

Good catch, fixed now!
 
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

thanks,

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/