linux-kernel - Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201512010847.SVw9zucX%fengguang.wu@intel.com>
Date:	Tue, 1 Dec 2015 08:04:48 +0800
From:	kbuild test robot <lkp@...el.com>
To:	David Decotigny <ddecotig@...il.com>
Cc:	kbuild-all@...org, "David S. Miller" <davem@...emloft.net>,
	Ben Hutchings <ben@...adent.org.uk>,
	Amir Vadai <amirv@...lanox.com>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, linux-api@...r.kernel.org,
	linux-mips@...ux-mips.org, fcoe-devel@...n-fcoe.org,
	Eric Dumazet <edumazet@...gle.com>,
	Eugenia Emantayev <eugenia@...lanox.co.il>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Ido Shamay <idos@...lanox.com>, Joe Perches <joe@...ches.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Govindarajulu Varadarajan <_govind@....com>,
	Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Eyal Perry <eyalpe@...lanox.com>,
	Pravin B Shelar <pshelar@...ira.com>,
	Ed Swierk <eswierk@...portsystems.com>,
	Robert Love <robert.w.love@...el.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Yuval Mintz <Yuval.Mintz@...gic.com>,
	David Decotigny <decot@...glers.com>
Subject: Re: [PATCH net-next v3 03/17] net: ethtool: add new
 ETHTOOL_GSETTINGS/SSETTINGS API

Hi David,

[auto build test WARNING on: net-next/master]
[also build test WARNING on: v4.4-rc3 next-20151127]

url:    https://github.com/0day-ci/linux/commits/David-Decotigny/RFC-new-ETHTOOL_GSETTINGS-SSETTINGS-API/20151201-062040
config: blackfin-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All warnings (new ones prefixed by >>):

   In file included from include/linux/netdevice.h:42:0,
                    from drivers/staging/rtl8723au/include/osdep_service.h:30,
                    from drivers/staging/rtl8723au/core/rtw_cmd.c:17:
   include/linux/ethtool.h: In function '__ethtool_add_link_modes':
>> include/linux/ethtool.h:129:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

vim +129 include/linux/ethtool.h

   113		struct {
   114			ethtool_link_mode_mask_t supported;
   115			ethtool_link_mode_mask_t advertising;
   116			ethtool_link_mode_mask_t lp_advertising;
   117		} link_modes;
   118	};
   119	
   120	/* helper function for ethtool_build_link_mode and ethtool_add_link_modes */
   121	static inline int
   122	__ethtool_add_link_modes(ethtool_link_mode_mask_t *dst,
   123				 unsigned nindices,
   124				 const enum ethtool_link_mode_bit_indices *indices) {
   125		unsigned i;
   126		int rv = 0;
   127	
   128		for (i = 0 ; i < nindices ; ++i) {
 > 129			if (__ETHTOOL_LINK_MODE_IS_VALID_BIT(indices[i]))
   130				set_bit(indices[i], dst->mask);
   131			else
   132				rv = -1;
   133		}
   134		return rv;
   135	}
   136	
   137	/* build link mode mask from variadic list of bit indices, return 0

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (39033 bytes)