linux-kernel - Re: [PATCH] regulator: core: Ensure we lock all regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151201165301.GM1929@sirena.org.uk>
Date:	Tue, 1 Dec 2015 16:53:01 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Thierry Reding <treding@...dia.com>, linux-kernel@...r.kernel.org,
	Tyler Baker <tyler.baker@...aro.org>
Subject: Re: [PATCH] regulator: core: Ensure we lock all regulators

On Tue, Dec 01, 2015 at 05:45:17PM +0100, Arnd Bergmann wrote:
> On Tuesday 01 December 2015 16:40:57 Mark Brown wrote:

> >         mutex_lock(&rdev->mutex);
> > -       for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++)
> > +       for (i = 1; rdev; rdev = rdev->supply->rdev, i++)
> >                 mutex_lock_nested(&rdev->mutex, i);

> I think now we have a double lock, the initial mutex_lock() needs to
> be removed again.

Ugh, I even made that fix before I sent but didn't actually commit it
:(

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)