linux-kernel - Re: [PATCH] usb: interface: allow drivers declare number of endpoints they need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151201170752.GB2714@kroah.com>
Date:	Tue, 1 Dec 2015 09:07:52 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Oliver Neukum <oneukum@...e.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Felipe Balbi <balbi@...com>,
	Vladis Dronov <vdronov@...hat.com>,
	USB list <linux-usb@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: interface: allow drivers declare number of
 endpoints they need

On Tue, Dec 01, 2015 at 08:53:57AM +0100, Oliver Neukum wrote:
> On Mon, 2015-11-30 at 17:09 -0800, Greg Kroah-Hartman wrote:
> > > that would loop through endpoints so that drivers do not have to
> > > open-code the loop and we indeed need to fix the drivers that
> > blindly
> > > grab endpoints at fixed offsets and expect them to be there and have
> > > correct types.
> > 
> > Yes, that would work for one single type of endpoint, but lots of
> > drivers need/have 2 of the same type/direction, so what would this
> > function do then?  Error out?  Hm, that might work, and it would
> > reduce
> > a bunch of common code, care to make up a patch for that?
> 
> Hi,
> 
> in that case let us go the whole way. Give drivers a way to describe
> what they need that covers all possibilities up to exactly telling the
> core what it expects and in which order and numbers.
> Actually that would be better in the interface matching code path.

Trying to describe a static, or variable, number of endpoints, for each
interface and endpoint type, and then add that information to the
usb_device_id structure and common macros, and then touch all users of
those macros, might be a bit too much work to do here... :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/