linux-kernel - Re: [PATCH] net: add support for netdev notifier error injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 01 Dec 2015 15:32:39 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	linux-kernel@...r.kernel.org, shm@...ulusnetworks.com,
	gospo@...ulusnetworks.com, roopa@...ulusnetworks.com,
	dsa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
	akinobu.mita@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: add support for netdev notifier error injection

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Sat, 28 Nov 2015 13:45:28 +0100

> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> This module allows to insert errors in some of netdevice's notifier
> events. All network drivers use these notifiers to signal various events
> and to check if they are allowed, e.g. PRECHANGEMTU and CHANGEMTU
> afterwards. Until recently I had to run failure tests by injecting
> a custom module, but now this infrastructure makes it trivial to test
> these failure paths. Some of the recent bugs I fixed were found using
> this module.
> Here's an example:
>  $ cd /sys/kernel/debug/notifier-error-inject/netdev
>  $ echo -22 > actions/NETDEV_CHANGEMTU/error
>  $ ip link set eth0 mtu 1024
>  RTNETLINK answers: Invalid argument
> 
> CC: Akinobu Mita <akinobu.mita@...il.com>
> CC: "David S. Miller" <davem@...emloft.net>
> CC: netdev <netdev@...r.kernel.org>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

This looks fine, applied to net-next, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/