linux-kernel - Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151201.153517.224543138214404348.davem@davemloft.net>
Date:	Tue, 01 Dec 2015 15:35:17 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mhocko@...nel.org
Cc:	pavel@....cz, akpm@...l.org, linux-kernel@...r.kernel.org,
	jcliburn@...il.com, chris.snook@...il.com, netdev@...r.kernel.org,
	rjw@...ysocki.net, linux-mm@...ck.org, nic-devel@...lcomm.com,
	ronangeles@...il.com, ebiederm@...ssion.com
Subject: Re: [PATCH] Improve Atheros ethernet driver not to do order 4
 GFP_ATOMIC allocation

From: Michal Hocko <mhocko@...nel.org>
Date: Mon, 30 Nov 2015 14:21:29 +0100

> On Sat 28-11-15 15:51:13, Pavel Machek wrote:
>> 
>> atl1c driver is doing order-4 allocation with GFP_ATOMIC
>> priority. That often breaks  networking after resume. Switch to
>> GFP_KERNEL. Still not ideal, but should be significantly better.
> 
> It is not clear why GFP_KERNEL can replace GFP_ATOMIC safely neither
> from the changelog nor from the patch context.

Earlier in the function we do a GFP_KERNEL kmalloc so: 

¯\_(ツ)_/¯

It should be fine.