Message-ID: <565E0E1D.1040505@codeaurora.org>
Date:	Tue, 1 Dec 2015 16:16:13 -0500
From:	Sinan Kaya <okaya@...eaurora.org>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	dmaengine@...r.kernel.org, timur@...eaurora.org,
	cov@...eaurora.org, jcm@...hat.com, agross@...eaurora.org,
	arnd@...db.de, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel
 driver

On 12/1/2015 6:34 AM, Vinod Koul wrote:
> On Mon, Nov 30, 2015 at 03:06:36PM -0500, Sinan Kaya wrote:
>> I have split the debugfs support from this patch to its own patch. Any
>> other idea on how else you'd break the code? I can take one more step
>> and separate the lower layer from the OS layer by using stub functions
>> on the initial commit.
> 
> Yes the ll.c can be a separate patch and no need to add placeholders as
> makefile can be last
> 

ok. I'll create a new patch file with the Makefile and hidma_ll.c only.

>>>
>>>> +static enum dma_status hidma_tx_status(struct dma_chan *dmach,
>>>> +			dma_cookie_t cookie, struct dma_tx_state *txstate)
>>>> +{
>>>> +	struct hidma_chan *mchan = to_hidma_chan(dmach);
>>>> +	enum dma_status ret;
>>>> +
>>>> +	if (mchan->paused)
>>>> +		ret = DMA_PAUSED;
>>>
>>> This is not quite right. The status query is for a descriptor and NOT for
>>> channel. Here if the descriptor queried was running then it would be paused
>>> for the rest pending txn, it would be DMA_IN_PROGRESS.
>>
>> The channel can be paused by the hypervisor. If it is paused, then no
>> other transaction will go through including the pending requests. That's
>> why, I'm checking the state first.
> 
> You are missing the point. Channel can be paused, yes but the descriptor
> is in queue and is not paused. The descriptor running is paused, yes.
> There is subtle difference between these

I'll follow your recommendation. PAUSE for the currently active
descriptor and DMA_IN_PROGRESS for the rest.

> 
>>>> +static dma_cookie_t hidma_tx_submit(struct dma_async_tx_descriptor *txd)
>>>> +{
>>>> +	struct hidma_chan *mchan = to_hidma_chan(txd->chan);
>>>> +	struct hidma_dev *dmadev = mchan->dmadev;
>>>> +	struct hidma_desc *mdesc;
>>>> +	unsigned long irqflags;
>>>> +	dma_cookie_t cookie;
>>>> +
>>>> +	if (!hidma_ll_isenabled(dmadev->lldev))
>>>> +		return -ENODEV;
>>>
>>> is this not too late for this check, you should fail this on prepare
>>> method
>>
>> The channels can be paused by the hypervisor at runtime after the guest
>> OS boot. The client might have allocated the channels during guest
>> machine boot. If a channel is paused and client makes a request, client
>> will never get the callback. By placing this check, I'm looking at the
>> runtime status of the channel and rejecting the transmit request right
>> ahead.
> 
> In this case you have request already given to you, here the request is
> submitted to the pending queue, 

No, it is not. Putting into the pending queue is done after this check
not before.

I'm rejecting the queue request directly here as HIDMA channel is no
longer functional. I'd rather do active error handling rather than
passive error handling. Debugging of passive faults are much more difficult.

> if hypervisor has paused you, so the entire
> txn queue is paused. But from API semantics I would argue that this should be
> accepted and suffer the same fate as already submitted txns
> 



>>
>>>
>>>
>>>> +static int hidma_alloc_chan_resources(struct dma_chan *dmach)
>>>> +{
>>>> +	struct hidma_chan *mchan = to_hidma_chan(dmach);
>>>> +	struct hidma_dev *dmadev = mchan->dmadev;
>>>> +	struct hidma_desc *mdesc, *tmp;
>>>> +	unsigned long irqflags;
>>>> +	LIST_HEAD(descs);
>>>> +	unsigned int i;
>>>> +	int rc = 0;
>>>> +
>>>> +	if (mchan->allocated)
>>>> +		return 0;
>>>> +
>>>> +	/* Alloc descriptors for this channel */
>>>> +	for (i = 0; i < dmadev->nr_descriptors; i++) {
>>>> +		mdesc = kzalloc(sizeof(struct hidma_desc), GFP_KERNEL);
>>>
>>> GFP_NOWAIT pls, this can be called from atomic context
>>
>> I'll change it, but why would anyone allocate a channel in an interrupt
>> handler?
> 
> remember this is dmaengine, where people traditionally wanted to offload
> from cpu and were not allowed to sleep.
> 
> I think am okay with this one..
> 
>>
>>>
>>>> +		if (!mdesc) {
>>>> +			rc = -ENOMEM;
>>>> +			break;
>>>> +		}
>>>> +		dma_async_tx_descriptor_init(&mdesc->desc, dmach);
>>>> +		mdesc->desc.flags = DMA_CTRL_ACK;
>>>
>>> what is the purpose of setting this flag here
>>
>> It means that the code only supports interrupt. Maybe, you can correct
>> me here. I couldn't see a very useful info about the DMA engine flags.
>> My understanding is that DMA_CTRL_ACK means user wants an interrupt
>> based callback.
> 
> Right user wants, you are not user though
> 

Fair enough.

>>
>> If DMA_CTRL_ACK is not specified, then user wants to poll for the
>> results. The current code only supports the interrupt based delivery for
>> callbacks. Polling support is another to-do in my list for small sized
>> transfers.
> 
> See the documentation for flags and usage. The point here is that user
> should set this. I know some old driver do this but that is not right
> 

I'll remove it.

>>
>>>
>>>
>>>> +static int hidma_remove(struct platform_device *pdev)
>>>> +{
>>>> +	struct hidma_dev *dmadev = platform_get_drvdata(pdev);
>>>> +
>>>> +	pm_runtime_get_sync(dmadev->ddev.dev);
>>>> +	dma_async_device_unregister(&dmadev->ddev);
>>>> +	hidma_debug_uninit(dmadev);
>>>> +	hidma_ll_uninit(dmadev->lldev);
>>>> +	hidma_free(dmadev);
>>>> +
>>>> +	dev_info(&pdev->dev, "HI-DMA engine removed\n");
>>>> +	pm_runtime_put_sync_suspend(&pdev->dev);
>>>> +	pm_runtime_disable(&pdev->dev);
>>>
>>> and your irq is still active and can invoke your irq handler!
>>>
>>
>> why? I shutdown the IRQ in hidma_ll_uninit and request the interrupt
>> with devm_request_irq. As soon as this driver is removed, the interrupt
>> should be released by the managed code.
> 
> but there is a delay between that and free getting called. Since you don't
> free up explicitly you can still have irq and tasklets scheduled.
> 
> Recommendation is that free up irq or ensure none are scheduled and
> disabled
> 
I looked at other drivers. They seem to be disabling the IRQ right after
unregistering the DMA device from DMA engine. I'll follow the same by
adding an explicit dma_free_irq call into hidma_remove function.


-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists