linux-kernel - Re: [v8, 2/6] fsl/fman: Add FMan support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 Dec 2015 16:28:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	igal.liberman@...escale.com
Cc:	netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, scottwood@...escale.com,
	madalin.bucur@...escale.com, pebolle@...cali.nl,
	joakim.tjernlund@...nsmode.se, ppc@...dchasers.com,
	stephen@...workplumber.org
Subject: Re: [v8, 2/6] fsl/fman: Add FMan support

From: <igal.liberman@...escale.com>
Date: Mon, 30 Nov 2015 14:20:58 +0200

> +typedef irqreturn_t (fman_exceptions_cb)(struct fman *fman,
> +					 enum fman_exceptions exception);

Function and function pointer declarations and definitions should be
indented such that the second and subsequent lines begin precisely
at the first column after the openning parenthesis of the first line.

Please audit this and fix it in your entire submission, almost ever
new such case is done incorrectly.

> +	fman->state->exceptions = (EX_DMA_BUS_ERROR                 |
> +					EX_DMA_READ_ECC              |
> +					EX_DMA_SYSTEM_WRITE_ECC      |
> +					EX_DMA_FM_WRITE_ECC          |
> +					EX_FPM_STALL_ON_TASKS        |
> +					EX_FPM_SINGLE_ECC            |
> +					EX_FPM_DOUBLE_ECC            |
> +					EX_QMI_DEQ_FROM_UNKNOWN_PORTID |
> +					EX_BMI_LIST_RAM_ECC          |
> +					EX_BMI_STORAGE_PROFILE_ECC   |
> +					EX_BMI_STATISTICS_RAM_ECC    |
> +					EX_MURAM_ECC                 |
> +					EX_BMI_DISPATCH_RAM_ECC      |
> +					EX_QMI_DOUBLE_ECC            |
> +					EX_QMI_SINGLE_ECC);

The same applies to multi-line parenthesized expressions like this
one.  Again, please audit and fix this in your entire submission.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/