linux-kernel - Re: [PATCH] parisc: Remove unused pcibios_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP6odjgr8va4nM2+Rr9gchkg28TctB-yd_n3reitwcUo=nmbCQ@mail.gmail.com>
Date:	Tue, 1 Dec 2015 14:02:11 -0800
From:	Grant Grundler <grantgrundler@...il.com>
To:	Helge Deller <deller@....de>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	open list <linux-kernel@...r.kernel.org>,
	linux-parisc <linux-parisc@...r.kernel.org>,
	Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [PATCH] parisc: Remove unused pcibios_init_bus()

On Tue, Dec 1, 2015 at 12:44 PM, Helge Deller <deller@....de> wrote:
> On 01.12.2015 17:41, Bjorn Helgaas wrote:
>> There are no callers of pcibios_init_bus(), so remove it.
>
> True, pcibios_init_bus() isn't called anywhere, so it should be removed.
>
> But I wonder if we might need to initialize latency and parity for PCI-PCI
> bridges somewhere else then?

pcibios_fixup_bus() appears to do that...but I don't know the call chain.
I used cscope to look for PCI_BRIDGE_CTL_PARITY.

> In one of my machines I have a i960 based RAID controller which isn't working
> yet (I think it's internally based on a PCI-PCI bridge), and maybe this
> is the reason it doesn't work? I will need to test it (e.g. firmware doesn't
> fully initializes PCI-PCI bridges, which is why this code was added once).

If lspci doesn't show the PCI-PCI bridge, the i960 RAID card is using
that internally.
parisc (and any other architecture) should discover and configure all
PCI-PCI bridges already.

I know it did for the "multifunction" cards I had available 10 years ago.

cheers,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/