linux-kernel - Re: [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Dec 2015 14:38:01 -0800
From:	Xavier Deguillard <xdeguillard@...are.com>
To:	Sinclair Yeh <syeh@...are.com>
Cc:	x86@...nel.org, pv-drivers@...are.com,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the
 VMW_PORT macro

Hey Sinclair,

On Tue, Dec 01, 2015 at 02:18:52PM -0800, Sinclair Yeh wrote:
> +#define VMWARE_BALLOON_CMD(cmd, data, result)			   \
> +({								   \
> +	unsigned long __status, __dummy1, __dummy2;		   \
> +	unsigned long __si = 0, __di = 0;			   \
> +	VMW_PORT(data, VMW_BALLOON_CMD_##cmd, VMW_BALLOON_HV_PORT, \
> +		 VMW_BALLOON_HV_MAGIC,				   \
> +		 __status, result, __dummy1, __dummy2, __si, __di);\
> +	if (VMW_BALLOON_CMD_##cmd == VMW_BALLOON_CMD_START)	   \
> +		result = __dummy1;				   \
> +	result &= -1UL;						   \
> +	__status & -1UL;					   \
>  })

You need to indent the '\' with tabs only, and it looks like spaces are
present here (which is also why they don't look aligned).

Other than that I'm good with this:

Acked-by: Xavier Deguillard <xdeguillard@...are.com>

Xavier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/