linux-kernel - Re: [PATCH] kvm: remove unused variable 'vcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878u5dk7si.fsf@gamma.ozlabs.ibm.com>
Date:	Wed, 02 Dec 2015 11:34:21 +1100
From:	Daniel Axtens <dja@...ens.net>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	"Geyslan G. Bem" <geyslan@...il.com>, kvm@...r.kernel.org,
	Gleb Natapov <gleb@...nel.org>, linux-kernel@...r.kernel.org,
	kvm-ppc@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
	Paolo Bonzini <pbonzini@...hat.com>,
	linuxppc-dev@...ts.ozlabs.org, Alexander Graf <agraf@...e.com>
Subject: Re: [PATCH] kvm: remove unused variable 'vcpu_book3s'

"Geyslan G. Bem" <geyslan@...il.com> writes:

> The vcpu_book3s struct is assigned but never used. So remove it.

Just out of interest, how did you find this? Compiler warning? Static
analysis? Manual inspection?

Thanks in advance!

Regards,
Daniel

>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> ---
>  arch/powerpc/kvm/book3s_64_mmu.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
> index 774a253..9bf7031 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu.c
> @@ -377,15 +377,12 @@ no_seg_found:
>  
>  static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
>  {
> -	struct kvmppc_vcpu_book3s *vcpu_book3s;
>  	u64 esid, esid_1t;
>  	int slb_nr;
>  	struct kvmppc_slb *slbe;
>  
>  	dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb);
>  
> -	vcpu_book3s = to_book3s(vcpu);
> -
>  	esid = GET_ESID(rb);
>  	esid_1t = GET_ESID_1T(rb);
>  	slb_nr = rb & 0xfff;
> -- 
> 2.6.2
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...ts.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

Download attachment "signature.asc" of type "application/pgp-signature" (860 bytes)