linux-kernel - Re: [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1449037288.656.23.camel@gmail.com>
Date:	Wed, 02 Dec 2015 07:21:28 +0100
From:	Mike Galbraith <umgwanakikbuti@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Marcelo Tosatti <mtosatti@...hat.com>,
	linux-kernel@...r.kernel.org,
	Luiz Capitulino <lcapitulino@...hat.com>,
	Chao Peng <chao.p.peng@...ux.intel.com>,
	Vikas Shivappa <vikas.shivappa@...el.com>
Subject: Re: [PATCH] cgroups: move cpuset specific checks from generic code
 to cpuset_can_attach (v2)

On Tue, 2015-12-01 at 11:49 -0500, Tejun Heo wrote:
> On Thu, Nov 26, 2015 at 08:32:32PM -0200, Marcelo Tosatti wrote:
> > 
> > Move PF_NO_SETAFFINITY and kthreadd_task checks to cpuset cgroups,  
> > where they belong. This makes it possible to attach PF_NO_SETAFFINITY 
> > tasks to Intel CAT cgroup.
> > 
> > Reported-by: Luiz Capitulino <lcapitulino@...hat.com>
> > Signed-off-by: Marcelo Tosatti <mtosatti@...hat.com>
> > Reviewed-by: Chao Peng <chao.p.peng@...ux.intel.com>
> > 
> > v2: "PF_NO_SETAFFINITY check" -> "PF_NO_SETAFFINITY and kthreadd_task
> > checks"
> 
> This wasn't just for cpuset.  It's for all controllers.

Hm, indeed.  Workers landing in a throttled cfs rq wouldn't be as
painful as an rt worker being born in an rq with no rt_runtime, but
could sting.  Workers stuffed into the freezer would sting mightily.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/