linux-kernel - [PATCH v2] PCI: imx6:don't sleep in atomic context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Dec 2015 13:13:16 +0530
From:	Sanjeev Sharma <sanjeev_sharma@...tor.com>
To:	<Richard.Zhu@...escale.com>, <l.stach@...gutronix.de>
CC:	<bhelgaas@...gle.com>, <linux-pci@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	David Mueller <dave.mueller@....ch>,
	Sanjeev Sharma <sanjeev_sharma@...tor.com>
Subject: [PATCH v2] PCI: imx6:don't sleep in atomic context

From: David Mueller <dave.mueller@....ch>

If additional PCIe switch get connected between the
host and the NIC,the kernel crashes with "BUG:
scheduling while atomic". To handle this we need to
call mdelay() instead of usleep_range().

This is currently called from atomic context through
pci_config_{read,write).

For more detail please refer bugzilla.kernel.org, Bug
100031

Signed-off-by: David Mueller <dave.mueller@....ch>
Signed-off-by: Sanjeev Sharma <sanjeev_sharma@...tor.com>

Changes in v2:
	-order of signoff has been change
	-Author of patch has been change
	-A mdelay(1000) is different timescale than
a usleep(1000).change it to correct scale i.e mdelay(1)
	-updated comment
---
 drivers/pci/host/pci-imx6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
index 233a196..c03527f 100644
--- a/drivers/pci/host/pci-imx6.c
+++ b/drivers/pci/host/pci-imx6.c
@@ -499,7 +499,7 @@ static int imx6_pcie_link_up(struct pcie_port *pp)
 		 * Wait a little bit, then re-check if the link finished
 		 * the training.
 		 */
-		usleep_range(1000, 2000);
+		mdelay(1);
 	}
 	/*
 	 * From L0, initiate MAC entry to gen2 if EP/RC supports gen2.
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/