[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACvgo501925ZkY_e3ryJv5kT9Es5sm45qmhcDdSeAfO3bDj8aw@mail.gmail.com>
Date: Wed, 2 Dec 2015 11:35:35 +0000
From: Emil Velikov <emil.l.velikov@...il.com>
To: Eric Anholt <eric@...olt.net>
Cc: ML dri-devel <dri-devel@...ts.freedesktop.org>,
"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/9] drm/vc4: Add an API for creating GPU shaders in GEM BOs.
Hi Eric,
On 1 December 2015 at 20:35, Eric Anholt <eric@...olt.net> wrote:
> Since we have no MMU, the kernel needs to validate that the submitted
> shader code won't make any accesses to memory that the user doesn't
> control, which involves banning some operations (general purpose DMA
> writes), and tracking where we need to write out pointers for other
> operations (texture sampling). Once it's validated, we return a GEM
> BO containing the shader, which doesn't allow mapping for write or
> exporting to other subsystems.
>
> Signed-off-by: Eric Anholt <eric@...olt.net>
> ---
> drivers/gpu/drm/vc4/Makefile | 3 +-
> drivers/gpu/drm/vc4/vc4_bo.c | 140 ++++++++
> drivers/gpu/drm/vc4/vc4_drv.c | 9 +-
> drivers/gpu/drm/vc4/vc4_drv.h | 50 +++
> drivers/gpu/drm/vc4/vc4_qpu_defines.h | 264 +++++++++++++++
May I suggest that one 'exports' the header to something like
libdrm_vc4 ? There are patches in flight for nouveau which in similar
fashion, allow userspare to reuse existing api/abi.
-Emil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists