linux-kernel - Re: [PATCH v2] Implement i8042 detect by BIOS FADT i8042 flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151202114510.GC3783@pd.tnic>
Date:	Wed, 2 Dec 2015 12:45:10 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Wan Zongshun <Vincent.Wan@....com>
Cc:	dmitry.torokhov@...il.coom, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, mcuos.com@...il.com
Subject: Re: [PATCH v2] Implement i8042 detect by BIOS FADT i8042 flag

On Wed, Dec 02, 2015 at 02:07:18PM -0500, Wan Zongshun wrote:
> Detecting x86 platform supporting i8042 or not, we should resort
> to BIOS's FADT i8042 flag per ACPI spec.
> 
> Currently, Windows is conforming to this spec, and request this
> flag to detect i8042 supporting.
> 
> Signed-off-by: Wan Zongshun <Vincent.Wan@....com>
> ---
>  drivers/input/serio/i8042-x86ia64io.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index c115565..73686bd 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -9,6 +9,7 @@
>  
>  #ifdef CONFIG_X86
>  #include <asm/x86_init.h>
> +#include <linux/acpi.h>
>  #endif
>  
>  /*
> @@ -1047,6 +1048,9 @@ static int __init i8042_platform_init(void)
>  	/* Just return if pre-detection shows no i8042 controller exist */
>  	if (!x86_platform.i8042_detect())
>  		return -ENODEV;
> +
> +	if (!(acpi_gbl_FADT.boot_flags & ACPI_FADT_8042))
> +		return -ENODEV;
>  #endif

Acked-by: Borislav Petkov <bp@...e.de>

with the small remark that whoever commits it, could add the URL of the
microsoft document to the commit message for further reference.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/