linux-kernel - Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C5A28EF7B98F574C85C70238C8E9ECC04E682BF158@ABGEX74E.FSC.NET>
Date:	Wed, 2 Dec 2015 13:34:38 +0100
From:	"Wilck, Martin" <martin.wilck@...fujitsu.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
CC:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
	"tpmdd-devel@...ts.sourceforge.net" 
	<tpmdd-devel@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Peter Huewe <peterhuewe@....de>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v2 0/3] tpm_tis: Clean up force module parameter

On Di, 2015-12-01 at 11:58 -0700, Jason Gunthorpe wrote:

> Martin, this should fix the double loading you noticed, please confirm.  There
> is a possibility the force path needs a bit more code to be compatible with
> devm_ioremap_resource, I'm not sure, hoping not.

Nope, this one oopses in the ACPI probing path.

[   12.287350] tpm_tis MSFT0101:00: invalid resource
[   12.292625] BUG: unable to handle kernel paging request at ffffffffffffffea
[   12.300427] IP: [<ffffffff81337481>] ioread8+0x31/0x40
[   12.306188] PGD 1a19067 PUD 1a1b067 PMD 0 
[   12.310793] Oops: 0000 [#1] SMP 
[   12.314416] Modules linked in: tpm_tis(+) nfsd auth_rpcgss nfs_acl lockd grace sunrpc sch_fq_codel ip_tables xfs libcrc32c sr_mod cdrom sd_mod mgag200 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ahci ttm libahci drm be2net vxlan libata ip6_udp_tunnel udp_tunnel
[   12.343483] CPU: 14 PID: 826 Comm: systemd-udevd Not tainted 4.4.0-rc2+ #15
[   12.351263] Hardware name: FUJITSU PRIMERGY RX2530 M1/D3279-B1, BIOS V5.0.0.11 R0.74.0 for D3279-B1x                    09/21/2015
[   12.364367] task: ffff88046bd52a80 ti: ffff88046bc94000 task.ti: ffff88046bc94000
[   12.372720] RIP: 0010:[<ffffffff81337481>]  [<ffffffff81337481>] ioread8+0x31/0x40
[   12.381205] RSP: 0018:ffff88046bc97a60  EFLAGS: 00010296
[   12.387142] RAX: ffffffffffffffea RBX: ffff88086ce27800 RCX: 0000000000000000
[   12.395113] RDX: 0000000000000001 RSI: ffff88086f10dff8 RDI: ffffffffffffffea
[   12.403077] RBP: ffff88046bc97ab0 R08: 000000000000000a R09: 0000000000000000
[   12.411042] R10: 0000000000000000 R11: 00000000000003ea R12: 00000000fffb9d01
[   12.419006] R13: ffff88086c6e0a68 R14: ffff88046bc97ad0 R15: ffff88046f4f8118
[   12.426972] FS:  00007fa4af348880(0000) GS:ffff88086f100000(0000) knlGS:0000000000000000
[   12.436002] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   12.442414] CR2: ffffffffffffffea CR3: 000000046bd7b000 CR4: 00000000001406e0
[   12.450378] Stack:
[   12.452622]  ffffffffa0121f21 ffff88046bc97ac0 ffffffffa0121600 ffff88046bc97ad0
[   12.460922]  0000000071883a14 ffff88086c6e0800 ffff88046bc97ad0 ffff88046bc97ac0
[   12.469221]  0000000000000009 ffff88046a44f540 ffff88046bc97b30 ffffffffa0122772
[   12.477518] Call Trace:
[   12.480252]  [<ffffffffa0121f21>] ? tpm_tis_init+0xf1/0x750 [tpm_tis]
[   12.487451]  [<ffffffffa0121600>] ? tpm_tis_probe_irq_single+0x160/0x160 [tpm_tis]
[   12.495894]  [<ffffffffa0122772>] tpm_tis_acpi_init+0xb2/0x120 [tpm_tis]
[   12.503387]  [<ffffffff81396e4a>] acpi_device_probe+0x4a/0xf7
[   12.509809]  [<ffffffff814564b9>] driver_probe_device+0x169/0x450
[   12.516620]  [<ffffffff81456825>] __driver_attach+0x85/0x90
[   12.522839]  [<ffffffff814567a0>] ? driver_probe_device+0x450/0x450
[   12.529837]  [<ffffffff8145427c>] bus_for_each_dev+0x6c/0xc0
[   12.536161]  [<ffffffff81455ece>] driver_attach+0x1e/0x20
[   12.542188]  [<ffffffff814559e0>] bus_add_driver+0x1d0/0x290
[   12.548510]  [<ffffffffa013d000>] ? 0xffffffffa013d000
[   12.554244]  [<ffffffff814571d0>] driver_register+0x60/0xe0
[   12.560463]  [<ffffffff81396d1e>] acpi_bus_register_driver+0x3b/0x43
[   12.567564]  [<ffffffffa013d08f>] init_tis+0x8f/0x1000 [tpm_tis]
[   12.574279]  [<ffffffff8132d8be>] ? kasprintf+0x4e/0x70
[   12.580116]  [<ffffffffa013d000>] ? 0xffffffffa013d000
[   12.585853]  [<ffffffff8100213d>] do_one_initcall+0xcd/0x1f0
[   12.592171]  [<ffffffff811d619b>] ? kmem_cache_alloc_trace+0x17b/0x1e0
[   12.599468]  [<ffffffff81179808>] ? do_init_module+0x27/0x1e8
[   12.605890]  [<ffffffff81179841>] do_init_module+0x60/0x1e8
[   12.612111]  [<ffffffff811002ae>] load_module+0x1c2e/0x24c0
[   12.618330]  [<ffffffff810fcab0>] ? __symbol_put+0x60/0x60
[   12.624453]  [<ffffffff810fce30>] ? copy_module_from_fd.isra.54+0x110/0x160
[   12.632229]  [<ffffffff81100d4f>] SyS_finit_module+0x9f/0xd0
[   12.638549]  [<ffffffff816bdb6e>] entry_SYSCALL_64_fastpath+0x12/0x71
[   12.645745] Code: 00 77 28 48 81 ff 00 00 01 00 76 08 0f b7 d7 ec 0f b6 c0 c3 55 48 c7 c6 10 fc 94 81 48 89 e5 e8 96 ff ff ff b8 ff 00 00 00 5d c3 <8a> 07 0f b6 c0 c3 66 0f 1f 84 00 00 00 00 00 48 81 ff ff ff 03 
[   12.667510] RIP  [<ffffffff81337481>] ioread8+0x31/0x40
[   12.673353]  RSP <ffff88046bc97a60>
[   12.677244] CR2: ffffffffffffffea
[   12.680943] ---[ end trace 5854533536fd5101 ]---
[   12.687465] Kernel panic - not syncing: Fatal exception
[   12.693338] Kernel Offset: disabled
[   12.701145] ---[ end Kernel panic - not syncing: Fatal exception