linux-kernel - Re: [PATCH 04/10] vfs: Distinguish between full xattr names and proper prefixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHc6FU5onrvj_f4V0KGDeKjULzpQxeZ4bjnQ=sGi1SDu0iK+FA@mail.gmail.com>
Date:	Wed, 2 Dec 2015 14:45:17 +0100
From:	Andreas Gruenbacher <agruenba@...hat.com>
To:	James Morris <jmorris@...ei.org>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 04/10] vfs: Distinguish between full xattr names and
 proper prefixes

On Tue, Dec 1, 2015 at 10:42 AM, James Morris <jmorris@...ei.org> wrote:
> On Mon, 30 Nov 2015, Andreas Gruenbacher wrote:
>
>> Add an additional "name" field to struct xattr_handler.  When the name
>> is set, the handler matches attributes with exactly that name.  When the
>> prefix is set instead, the handler matches attributes with the given
>> prefix and with a non-empty suffix.
>>
>> This patch should avoid bugs like the one fixed in commit c361016a in
>> the future.
>>
>> Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>
>
> Is it worth making an inline wrapper for 'handler->prefix ?:
> handler->name' ?

Yes, I did that.

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/