lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Dec 2015 17:10:16 +0100 From: Ludovic Desroches <ludovic.desroches@...el.com> To: <vinod.koul@...el.com> CC: <linux-arm-kernel@...ts.infradead.org>, <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <Sylvain.ETIENNE@...enico.com>, <ludovic.desroches@...el.com>, <nicolas.ferre@...el.com>, <maxime.ripard@...e-electrons.com> Subject: [PATCH] dmaengine: at_xdmac: fix bad behavior in interleaved mode From: Sylvain ETIENNE <Sylvain.ETIENNE@...enico.com> When performing interleaved transfers with numf > 1, an extra line is copied. The mbr.bc field is incremented once too often. The length of the block is (BLEN+1) microblocks. Signed-off-by: Sylvain ETIENNE <Sylvain.ETIENNE@...enico.com> Signed-off-by: Ludovic Desroches <ludovic.desroches@...el.com> Fixes: 4e5385784e69 ("dmaengine: at_xdmac: handle numf > 1") --- drivers/dma/at_xdmac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 7f039de..c8faaa5 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -965,7 +965,9 @@ at_xdmac_prep_interleaved(struct dma_chan *chan, NULL, src_addr, dst_addr, xt, xt->sgl); - for (i = 0; i < xt->numf; i++) + + /* Length of the block is (BLEN+1) microblocks. */ + for (i = 0; i < xt->numf - 1; i++) at_xdmac_increment_block_count(chan, first); dev_dbg(chan2dev(chan), "%s: add desc 0x%p to descs_list 0x%p\n", -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists