linux-kernel - [PATCH v3 5/8] platform: goldfish: pipe: don't log when dropping PIPE_ERROR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1449084968-30211-5-git-send-email-jinqian@android.com>
Date:	Wed,  2 Dec 2015 11:36:00 -0800
From:	Jin Qian <jinqian@...roid.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Greg Hackmann <ghackmann@...gle.com>,
	Christoffer Dall <christoffer.dall@...aro.org>,
	Joe Perches <joe@...ches.com>,
	Jason Hu <jia-cheng.hu@...el.com>, Yu Ning <yu.ning@...el.com>,
	Peter Senna Tschudin <peter.senna@...il.com>,
	Alex Bennée <alex.bennee@...aro.org>,
	linux-kernel@...r.kernel.org
Cc:	Jin Qian <jinqian@...roid.com>
Subject: [PATCH v3 5/8] platform: goldfish: pipe: don't log when dropping PIPE_ERROR_AGAIN

From: Greg Hackmann <ghackmann@...gle.com>

On PIPE_ERROR_AGAIN, just stopping in the middle of a transfer and
returning the number of bytes actually handled is the right behavior.

Other errors should be returned on the next read() or write() call.
Continue logging those until we confirm nothing actually relies on the
existing (wrong) behavior of dropping errors on the floor.

Signed-off-by: Greg Hackmann <ghackmann@...gle.com>
Signed-off-by: Jin Qian <jinqian@...roid.com>
---
 drivers/platform/goldfish/goldfish_pipe.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 0b187ff..7a56be9 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -346,7 +346,8 @@ static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer,
 			 * cannot change it until we check if any user space
 			 * ABI relies on this behavior.
 			 */
-			pr_info_ratelimited("android_pipe: backend returned error %d on %s\n",
+			if (status != PIPE_ERROR_AGAIN)
+				pr_info_ratelimited("goldfish_pipe: backend returned error %d on %s\n",
 					status, is_write ? "write" : "read");
 			ret = 0;
 			break;
-- 
2.6.0.rc2.230.g3dd15c0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/