linux-kernel - Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151202195657.GB11127@agk-dp.fab.redhat.com>
Date:	Wed, 2 Dec 2015 19:56:57 +0000
From:	Alasdair G Kergon <agk@...hat.com>
To:	Baolin Wang <baolin.wang@...aro.org>
Cc:	Mark Brown <broonie@...nel.org>, Jens Axboe <axboe@...nel.dk>,
	keith.busch@...el.com, Jan Kara <jack@...e.cz>,
	Arnd Bergmann <arnd@...db.de>,
	Mike Snitzer <snitzer@...hat.com>, neilb@...e.com,
	LKML <linux-kernel@...r.kernel.org>, linux-raid@...r.kernel.org,
	dm-devel@...hat.com, "Garg, Dinesh" <dineshg@...cinc.com>,
	tj@...nel.org, bart.vanassche@...disk.com, jmoyer@...hat.com,
	Alasdair G Kergon <agk@...hat.com>,
	Mikulas Patocka <mpatocka@...hat.com>
Subject: Re: [dm-devel] [PATCH 0/2] Introduce the request handling for
	dm-crypt

On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote:
> These are the benchmarks for request based dm-crypt. Please check it.

Now please put request-based dm-crypt completely to one side and focus
just on the existing bio-based code.  Why is it slower and what can be
adjusted to improve this?

People aren't going to take a request-based solution seriously until
you can explain in full detail *why* bio-based is slower AND why it's
impossible to improve its performance.

> For request based things, some sequential bios/requests can merged
> into one request to expand the IO size to be a big block handled by
> hardware engine at one time. 

Bio-based also merges I/O so that does not provide justification.
Investigate in much more detail the actual merging and scheduling
involved in the cases you need to optimise.  See if blktrace gives you
any clues, or add your own instrumentation.  You could even look at some
of the patches we've had in the list archives for optimising bio-based
crypt in different situations.

Alasdair

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/