linux-kernel - Re: [PATCH v5] sched/deadline: fix earliest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <565FFF5F.3000303@unitn.it>
Date:	Thu, 3 Dec 2015 09:37:51 +0100
From:	Luca Abeni <luca.abeni@...tn.it>
To:	Wanpeng Li <kernellwp@...il.com>
Cc:	Wanpeng Li <wanpeng.li@...mail.com>,
	Juri Lelli <juri.lelli@....com>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] sched/deadline: fix earliest_dl.next logic

Hi,

On 12/03/2015 03:25 AM, Wanpeng Li wrote:
[...]
>> @@ -202,16 +197,18 @@ static void dequeue_pushable_dl_task(struct rq *rq,
>> struct task_struct *p)
>>
>>                  next_node = rb_next(&p->pushable_dl_tasks);
>>                  dl_rq->pushable_dl_tasks_leftmost = next_node;
>> +               if (next_node)
>> +                       dl_rq->earliest_dl.next = rb_entry(next_node,
>> +                            struct task_struct,
>> pushable_dl_tasks)->dl.deadline;
>
> Juri mentioned "updated leftmost", I'm not sure if it means that:
>
> @@ -195,6 +195,9 @@ static void dequeue_pushable_dl_task(struct rq
> *rq, struct task_struct *p)
>
>                  next_node = rb_next(&p->pushable_dl_tasks);
>                  dl_rq->pushable_dl_tasks_leftmost = next_node;
> +               if (dl_rq->pushable_dl_tasks_leftmost)
> +                       dl_rq->earliest_dl.next =
> rb_entry(dl_rq->pushable_dl_tasks_leftmost,
> +                               struct task_struct,
> pushable_dl_tasks)->dl.deadline;
>          }
This is basically the same thing I tested (I just used "next_node" instead
of "dl_rq->pushable_dl_tasks_leftmost" because the name is shorter), so I
think it should work.


			Luca
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/