linux-kernel - Re: [PATCH] USB: host: ohci-at91: fix a crash in ohci_hcd_at91_overcurrent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <566000A8.7070107@atmel.com>
Date:	Thu, 3 Dec 2015 09:43:20 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	<linux-usb@...r.kernel.org>, Peter Rosin <peda@...ator.liu.se>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: host: ohci-at91: fix a crash in
 ohci_hcd_at91_overcurrent_irq

Le 02/12/2015 20:36, Alexandre Belloni a écrit :
> The interrupt handler, ohci_hcd_at91_overcurrent_irq may be called right
> after registration. At that time, pdev->dev.platform_data is not yet set,
> leading to a NULL pointer dereference.
> 
> Fixes: e4df92279fd9 (USB: host: ohci-at91: merge loops in ohci_hcd_at91_drv_probe)

Yes, with:
Cc: stable@...r.kernel.org # 4.3+


> Reported-by: Peter Rosin <peda@...ntia.se>
> Tested-by: Peter Rosin <peda@...ntia.se>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Alan, I think it's a good candidate to enter the 4.4-rcX...

Thanks, bye.

> ---
>  drivers/usb/host/ohci-at91.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index 342ffd140122..8c6e15bd6ff0 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -473,6 +473,8 @@ static int ohci_hcd_at91_drv_probe(struct platform_device *pdev)
>  	if (!pdata)
>  		return -ENOMEM;
>  
> +	pdev->dev.platform_data = pdata;
> +
>  	if (!of_property_read_u32(np, "num-ports", &ports))
>  		pdata->ports = ports;
>  
> @@ -483,6 +485,7 @@ static int ohci_hcd_at91_drv_probe(struct platform_device *pdev)
>  		 */
>  		if (i >= pdata->ports) {
>  			pdata->vbus_pin[i] = -EINVAL;
> +			pdata->overcurrent_pin[i] = -EINVAL;
>  			continue;
>  		}
>  
> @@ -513,10 +516,8 @@ static int ohci_hcd_at91_drv_probe(struct platform_device *pdev)
>  	}
>  
>  	at91_for_each_port(i) {
> -		if (i >= pdata->ports) {
> -			pdata->overcurrent_pin[i] = -EINVAL;
> -			continue;
> -		}
> +		if (i >= pdata->ports)
> +			break;
>  
>  		pdata->overcurrent_pin[i] =
>  			of_get_named_gpio_flags(np, "atmel,oc-gpio", i, &flags);
> @@ -552,8 +553,6 @@ static int ohci_hcd_at91_drv_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> -	pdev->dev.platform_data = pdata;
> -
>  	device_init_wakeup(&pdev->dev, 1);
>  	return usb_hcd_at91_probe(&ohci_at91_hc_driver, pdev);
>  }
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/