linux-kernel - Re: [PATCH] ASoC: da7218: Enable mic level detection reporting to user-space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk2ovn6ml.wl-tiwai@suse.de>
Date:	Thu, 03 Dec 2015 11:55:46 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Adam Thomson" <Adam.Thomson.Opensource@...semi.com>
Cc:	"Liam Girdwood" <lgirdwood@...il.com>,
	"Mark Brown" <broonie@...nel.org>,
	"Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
	"SupportOpensource" <support.opensource@...semi.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: da7218: Enable mic level detection reporting to user-space

On Thu, 03 Dec 2015 11:45:50 +0100,
Adam Thomson wrote:
> 
> This patch adds support to the codec driver to handle mic level
> detect related IRQs, and report these to user-space using a uevent
> variable.

Is the uevent the best way for this?


thanks,

Takashi

> 
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> ---
>  sound/soc/codecs/da7218.c | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
> index 4fee7ae..752ed04 100644
> --- a/sound/soc/codecs/da7218.c
> +++ b/sound/soc/codecs/da7218.c
> @@ -2202,6 +2202,16 @@ int da7218_hpldet(struct snd_soc_codec *codec, struct snd_soc_jack *jack)
>  }
>  EXPORT_SYMBOL_GPL(da7218_hpldet);
> 
> +static void da7218_micldet_irq(struct snd_soc_codec *codec)
> +{
> +	char *envp[] = {
> +		"EVENT=MIC_LEVEL_DETECT",
> +		NULL,
> +	};
> +
> +	kobject_uevent_env(&codec->dev->kobj, KOBJ_CHANGE, envp);
> +}
> +
>  static void da7218_hpldet_irq(struct snd_soc_codec *codec)
>  {
>  	struct da7218_priv *da7218 = snd_soc_codec_get_drvdata(codec);
> @@ -2232,6 +2242,10 @@ static irqreturn_t da7218_irq_thread(int irq, void *data)
>  	if (!status)
>  		return IRQ_NONE;
> 
> +	/* Mic level detect */
> +	if (status & DA7218_LVL_DET_EVENT_MASK)
> +		da7218_micldet_irq(codec);
> +
>  	/* HP detect */
>  	if (status & DA7218_HPLDET_JACK_EVENT_MASK)
>  		da7218_hpldet_irq(codec);
> @@ -2936,11 +2950,6 @@ static int da7218_probe(struct snd_soc_codec *codec)
>  	}
> 
>  	if (da7218->irq) {
> -		/* Mask off mic level events, currently not handled */
> -		snd_soc_update_bits(codec, DA7218_EVENT_MASK,
> -				    DA7218_LVL_DET_EVENT_MSK_MASK,
> -				    DA7218_LVL_DET_EVENT_MSK_MASK);
> -
>  		ret = devm_request_threaded_irq(codec->dev, da7218->irq, NULL,
>  						da7218_irq_thread,
>  						IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> --
> 1.9.3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/