linux-kernel - Re: [PATCH] staging: skein: cleans up macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20151203154720.GJ6520@io.lakedaemon.net>
Date:	Thu, 3 Dec 2015 15:47:20 +0000
From:	Jason Cooper <jason@...edaemon.net>
To:	Sanidhya Solanki <jpage@...anota.de>
Cc:	Gregkh <gregkh@...uxfoundation.org>, mathieu.poirier@...aro.org,
	deepa.kernel@...il.com, brcnakalin@...il.com,
	vatikaharlalka@...il.com, devel@...verdev.osuosl.org,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: skein: cleans up macros

Sanidhya,

Sorry I haven't been very responsive, but I'm glad to see your progress
here.

Once you make the recommended changes, try using 'git format-patch' and
'git send-email' to pick and send the patch to the mailinglists.

On Tue, Dec 01, 2015 at 08:42:28AM +0000, Sanidhya Solanki wrote:
> Patch moves the headers found in the "skein_block.c" to "skein_block.h".

Please reword:

The original code defined macros in the source code, making it harder to
read.  Move them to the header file.

> Compiled & checked: no errors found.

If you want to let us know this, you can put these kinds of comments
below the '---' ...

> Signed-off-by: Sanidhya Solanki <jpage@...anota.de>
> ---

Which is here.  That will prevent them from becoming a part of the
commit log.

>  drivers/staging/skein/skein_block.c | 321 
> -----------------------------------
>  drivers/staging/skein/skein_block.h | 323 
> ++++++++++++++++++++++++++++++++++++
>  2 files changed, 323 insertions(+), 321 deletions(-)

using the git tools mentioned above will prevent these kinds of wrapping
problems, which also affect the content of the patch.

Also, if this completes the TODO item, please include the change
removing the item from TODO.

Since this is your first submission, I'll toss this out there:  Don't go
redo the work to make the recommended changes.  git is designed to help
with this.

Say you were developing on the git branch 'my_changes',

$ git checkout -b my_changes_v2 my_changes
$ $EDITOR drivers/staging/skein/TODO
$ git add drivers/staging/skein/TODO
$ git commit -m "fixup: add TODO changes"
$ git rebase -i HEAD^^
	change 'pick' to 'fixup' for the last commit
	save and exit
$ git show
	confirm one commit has everything
$ git format-patch ...
$ $EDITOR 0001-*.patch
$ git send-email ...

If it gets all fouled up, don't panic.  you can checkout 'my_changes'
and it's in it's original state.  :-)

hth,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/