linux-kernel - Re: [PATCH] PCI: MSI: Only use the generic MSI layer when domain is hierarchical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56607130.2010002@arm.com>
Date:	Thu, 03 Dec 2015 16:43:28 +0000
From:	Marc Zyngier <marc.zyngier@....com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Phil Edworthy <phil.edworthy@...esas.com>,
	linux-kernel@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH] PCI: MSI: Only use the generic MSI layer when domain
 is hierarchical

On 23/11/15 17:38, Thomas Gleixner wrote:
> On Mon, 23 Nov 2015, Marc Zyngier wrote:
> 
>> Since d8a1cb757550 ("PCI/MSI: Let pci_msi_get_domain use struct
>> device::msi_domain"), we use the MSI domain associated to the PCI device.
>>
>> But finding a MSI domain doesn't mean that the domain is implemented
>> using the generic MSI domain API, and a number of MSI controllers
>> are still using the arch_setup_msi_irq/arch_teardown_msi_irqs.
>>
>> In order to avoid a firework on these systems, check that the domain
>> we just obtained is hierarchical. If not, don't use the generic MSI
>> stuff and stick with the old one. Not pretty, but reliable.
>>
>> Another insentive to rework those drivers and phase out this API.
>>
>> Reported-by: Phil Edworthy <phil.edworthy@...esas.com>
>> Tested-by: Phil Edworthy <phil.edworthy@...esas.com>
>> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
> 
> Acked-by: Thomas Gleixner <tglx@...utronix.de>
> 

Hi Bjorn,

Do you have any objection to taking this patch? It fixes a real issue
for drivers not using the generic MSI domains.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/