linux-kernel - Re: [BUG] checkpatch: false positive for commits with quote characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Dec 2015 16:13:18 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [BUG] checkpatch: false positive for commits with quote
 characters

Ping? I've hit some different false positives today on the same rule.
I'll stop bothering to report them if no one cares.

On Tue, Nov 17, 2015 at 10:03:36AM -0800, Brian Norris wrote:
> On Tue, Nov 17, 2015 at 09:48:27AM -0800, Joe Perches wrote:
> > On Mon, 2015-11-16 at 14:43 -0800, Brian Norris wrote:
> > > Hi,
> > > 
> > > What is the Blessed (TM) style for referencing commits that have quote
> > > characters in their subject line? e.g., this commit:
> > > 
> > > commit 43163022927b6e7d202a7e6f939c3f392465494d
> > > Author: Brian Norris <computersforpeace@...il.com>
> > > Date:   Tue May 19 14:38:22 2015 -0700
> > > 
> > >     mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"
> > > 
> > > Checkpatch reports false positive errors like this:
> > > 
> > >   ERROR: Please use git commit description style 'commit <12+ chars of
> > >   sha1> ("")'
> > 
> > Hi Brian.
> > 
> > What version of checkpatch are you using?
> > 
> > Using linux-next:
> > 
> > $ git log --stat -p -1 --format=email 43163022927b6e7d202a7e6f939c3f392465494d | ./scripts/checkpatch.pl --strict -
> 
> I was referring to running checkpatch on this:
> 
>   https://lkml.org/lkml/2015/11/16/826
> 
> which *referenced* commit 43163022927b6e7d202a7e6f939c3f392465494d.
> Sorry if that wasn't clear.
> 
> See below,
> Brian
> 
> $ curl http://patchwork.ozlabs.org/patch/545234/mbox/ | scripts/checkpatch.pl -
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 100  3741    0  3741    0     0  11525      0 --:--:-- --:--:-- --:--:-- 11510
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"")'
> #17: 
> Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for
> 
> total: 1 errors, 0 warnings, 29 lines checked
> 
> Your patch has style problems, please review.
> 
> NOTE: Ignored message types: FILE_PATH_CHANGES
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/