linux-kernel - Re: [PATCH v6] sched/deadline: fix earliest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151204101144.GG17308@twins.programming.kicks-ass.net>
Date:	Fri, 4 Dec 2015 11:11:44 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Juri Lelli <juri.lelli@....com>
Cc:	Wanpeng Li <kernellwp@...il.com>, Ingo Molnar <mingo@...nel.org>,
	Luca Abeni <luca.abeni@...tn.it>, linux-kernel@...r.kernel.org,
	Wanpeng Li <wanpeng.li@...mail.com>
Subject: Re: [PATCH v6] sched/deadline: fix earliest_dl.next logic

On Fri, Dec 04, 2015 at 09:59:52AM +0000, Juri Lelli wrote:
> > +		if (next_node)
> > +			dl_rq->earliest_dl.next = rb_entry(next_node,
> > +				struct task_struct, pushable_dl_tasks)->dl.deadline;
> 
> Small nitpick, we are breaking 80 columns here, checkpatch should have
> complained. I guess a different indentation could help.
> 
> Apart from this, I couldn't spot any more problems with this patch.

So I don't mind the occasional violation of that rule if it aids in
better readable code.

However, that should now have included {} because the statement is
multi-line. Coding style suggests we have braces for anything over 1
line. I'll make that edit when applying, no need to resend yet another
time :-)

> Acked-by: Juri Lelli <juri.lelli@....com>

Thanks, I'll try and get it queued later today.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/