linux-kernel - Re: [PATCH] Staging: cdrom: fix space required after that ','

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 Dec 2015 07:37:34 -0300
From:	"Geyslan G. Bem" <geyslan@...il.com>
To:	"Shah, Yash (Y.)" <yshah1@...teon.com>
Cc:	"axboe@...nel.dk" <axboe@...nel.dk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Babu, Viswanathan (V.)" <vbabu3@...teon.com>
Subject: Re: [PATCH] Staging: cdrom: fix space required after that ','

Hi Yash,

2015-12-04 6:21 GMT-03:00 Shah, Yash (Y.) <yshah1@...teon.com>:
> From: Yash Shah<yshah1@...teon.com>
>
> fix space required after that ',' as detected by checkpatch.pl
>
> Signed-off-by: Yash Shah <yshah1@...teon.com>
> ---
>  drivers/cdrom/cdrom.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index c206ccd..2d759b6 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -536,7 +536,7 @@ static int cdrom_mrw_exit(struct cdrom_device_info *cdi)
>         int ret;
>
>         ret = cdrom_get_disc_info(cdi, &di);
> -       if (ret < 0 || ret < (int)offsetof(typeof(di),disc_type))
> +       if (ret < 0 || ret < (int)offsetof(typeof(di), disc_type))
>                 return 1;
>
>         ret = 0;
> @@ -788,7 +788,7 @@ static int cdrom_mrw_open_write(struct cdrom_device_info *cdi)
>         }
>
>         ret = cdrom_get_disc_info(cdi, &di);
> -       if (ret < 0 || ret < offsetof(typeof(di),disc_type))
> +       if (ret < 0 || ret < offsetof(typeof(di), disc_type))
>                 return 1;
>
>         if (!di.erasable)
> @@ -1050,7 +1050,7 @@ int open_for_data(struct cdrom_device_info *cdi)
>                         if (CDROM_CAN(CDC_CLOSE_TRAY) &&
>                             cdi->options & CDO_AUTO_CLOSE) {
>                                 cd_dbg(CD_OPEN, "trying to close the tray\n");
> -                               ret=cdo->tray_move(cdi,0);
> +                               ret=cdo->tray_move(cdi, 0);

What do you think to add spaces between equal assignment too?

>                                 if (ret) {
>                                         cd_dbg(CD_OPEN, "bummer. tried to close the tray but failed.\n");
>                                         /* Ignore the error from the low
> @@ -1215,7 +1215,7 @@ static int check_for_audio_disc(struct cdrom_device_info * cdi,
>                         if (CDROM_CAN(CDC_CLOSE_TRAY) &&
>                             cdi->options & CDO_AUTO_CLOSE) {
>                                 cd_dbg(CD_OPEN, "trying to close the tray\n");
> -                               ret=cdo->tray_move(cdi,0);
> +                               ret=cdo->tray_move(cdi, 0);
>                                 if (ret) {
>                                         cd_dbg(CD_OPEN, "bummer. tried to close tray but failed.\n");
>                                         /* Ignore the error from the low
> @@ -1591,8 +1591,8 @@ void init_cdrom_command(struct packet_command *cgc, void *buf, int len,
>
>  /* DVD handling */
>
> -#define copy_key(dest,src)     memcpy((dest), (src), sizeof(dvd_key))
> -#define copy_chal(dest,src)    memcpy((dest), (src), sizeof(dvd_challenge))
> +#define copy_key(dest, src)    memcpy((dest), (src), sizeof(dvd_key))
> +#define copy_chal(dest, :src)  memcpy((dest), (src), sizeof(dvd_challenge))
>
>  static void setup_report_key(struct packet_command *cgc, unsigned agid, unsigned type)
>  {
> --
> 1.9.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/