[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20151204121623.GA26072@sirena.org.uk>
Date: Fri, 4 Dec 2015 12:16:23 +0000
From: Mark Brown <broonie@...nel.org>
To: Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH 6/7] spi: lm70llp: remove printk
On Thu, Dec 03, 2015 at 06:29:58PM +0530, Sudip Mukherjee wrote:
> Using pr_* macros are more prefferable than using printk. Start using
> pr_* family of macros and define pr_fmt to be used with it.
> While at it remove DRVNAME from an existing pr_info() as the name is now
> being printed by pr_fmt.
> @@ -246,9 +245,7 @@ static void spi_lm70llp_attach(struct parport *p)
> */
> status = spi_bitbang_start(&pp->bitbang);
> if (status < 0) {
> - printk(KERN_WARNING
> - "%s: spi_bitbang_start failed with status %d\n",
> - DRVNAME, status);
> + pr_warn("spi_bitbang_start failed with status %d\n", status);
> goto out_off_and_release;
> }
>
When we have a struct device available it's even better to use
dev_warn() and so on.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists