linux-kernel - Re: [PATCH 2/7] perf test: Use machine__new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151204132215.GF22102@danjae.kornet>
Date:	Fri, 4 Dec 2015 22:22:15 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	HIRAMATU，MASAMI 
	<masami.hiramatsu.pt@...achi.com>, Wang Nan <wangnan0@...wei.com>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 2/7] perf test: Use machine__new_host in mma thread
 lookup test

Hi Jiri,

In the subject, please do 's/mma/mmap/'.  Ditto for 3/7.

Thanks,
Namhyung


On Thu, Dec 03, 2015 at 09:34:13AM +0100, Jiri Olsa wrote:
> This is more straightforward than what we have now.
> 
> It also fixes segfault within machine__exit, that's caused
> but not creating kernel maps for machine.. We're calling
> machine__destroy_kernel_maps in machine__exit since commit:
> 
>   ebe9729c8c31 perf machine: Fix to destroy kernel maps when machine exits
> 
> Link: http://lkml.kernel.org/n/tip-h20rqr6nyuqvcjqdmixvy9fn@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/perf/tests/mmap-thread-lookup.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/tests/mmap-thread-lookup.c b/tools/perf/tests/mmap-thread-lookup.c
> index 6cdb97579c45..0c5ce44f723f 100644
> --- a/tools/perf/tests/mmap-thread-lookup.c
> +++ b/tools/perf/tests/mmap-thread-lookup.c
> @@ -149,7 +149,6 @@ static int synth_process(struct machine *machine)
>  
>  static int mmap_events(synth_cb synth)
>  {
> -	struct machines machines;
>  	struct machine *machine;
>  	int err, i;
>  
> @@ -162,8 +161,7 @@ static int mmap_events(synth_cb synth)
>  	 */
>  	TEST_ASSERT_VAL("failed to create threads", !threads_create());
>  
> -	machines__init(&machines);
> -	machine = &machines.host;
> +	machine = machine__new_host();
>  
>  	dump_trace = verbose > 1 ? 1 : 0;
>  
> @@ -203,7 +201,7 @@ static int mmap_events(synth_cb synth)
>  	}
>  
>  	machine__delete_threads(machine);
> -	machines__exit(&machines);
> +	machine__delete(machine);
>  	return err;
>  }
>  
> -- 
> 2.4.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/