linux-kernel - Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo51e3DvNzjVxAxtoqeaanLdy4qq1jSHBDUSr=ubkOjyS9Q@mail.gmail.com>
Date:	Fri, 4 Dec 2015 14:29:34 +0000
From:	Emil Velikov <emil.l.velikov@...il.com>
To:	Eric Anholt <eric@...olt.net>
Cc:	ML dri-devel <dri-devel@...ts.freedesktop.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls.

Hi Eric,

A couple of suggestions/requests on the UAPI header side

On 1 December 2015 at 20:35, Eric Anholt <eric@...olt.net> wrote:

> --- /dev/null
> +++ b/include/uapi/drm/vc4_drm.h

> +#include <drm/drm.h>
> +
Can we make this a "drm.h" ?


> +struct drm_vc4_create_bo {
> +       uint32_t size;
> +       uint32_t flags;
> +       /** Returned GEM handle for the BO. */
> +       uint32_t handle;
> +       uint32_t pad;
... and not use the stdint.h types but __{s,u}* through the file.

I'd rather than not nag why we want/need those, but if you prefer I
can repeat myself/others.

Thanks
Emil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/