linux-kernel - Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory regions above MAX_DMA32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 4 Dec 2015 15:34:14 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Igor Mammedov <imammedo@...hat.com>, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	konrad.wilk@...cle.com, akataria@...are.com,
	fujita.tomonori@....ntt.co.jp, revers@...hat.com, riel@...hat.com
Subject: Re: [PATCH v2 2/2] x86_64: enable SWIOTLB if system has SRAT memory
 regions above MAX_DMA32_PFN


* Paolo Bonzini <pbonzini@...hat.com> wrote:

> On 04/12/2015 13:33, Igor Mammedov wrote:
> > That doesn't pass strict type check:
> > 
> > include/linux/kernel.h:730:17: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> >   (void) (&_max1 == &_max2);  \
> >                  ^
> > arch/x86/mm/srat.c:206:21: note: in expansion of macro ‘max’
> >   max_possible_pfn = max(max_possible_pfn, PFN_UP(end - 1));
> > 
> > I can change max_possible_pfn to u64 to match PFN_UP(end - 1) type.
> 
> Sounds like a good idea anyway.

Yeah, agreed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/