linux-kernel - Re: [PATCH] mmc: of_mmc_spi: Add IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrsa_+ygaaFV_BWLNLtCXc70-VXtZ7=9cSjFHHXFW1pQg@mail.gmail.com>
Date:	Fri, 4 Dec 2015 15:56:12 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Saurabh Sengar <saurabh.truth@...il.com>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: of_mmc_spi: Add IRQF_ONESHOT to interrupt flags

On 25 November 2015 at 19:26, Saurabh Sengar <saurabh.truth@...il.com> wrote:
> If no primary handler is specified for threaded_irq then a
> default one is assigned which always returns IRQ_WAKE_THREAD.
> This handler requires the IRQF_ONESHOT, because the source of
> interrupt is not disabled
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/of_mmc_spi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index 6e218fb..660170c 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -55,8 +55,8 @@ static int of_mmc_spi_init(struct device *dev,
>  {
>         struct of_mmc_spi *oms = to_of_mmc_spi(dev);
>
> -       return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
> -                                   dev_name(dev), mmc);
> +       return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
> +                                       IRQF_ONESHOT, dev_name(dev), mmc);
>  }
>
>  static void of_mmc_spi_exit(struct device *dev, void *mmc)
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/