linux-kernel - [PATCH] trace-cmd: quiet some output when using libtracecmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1449243450-4280-1-git-send-email-jbacik@fb.com>
Date:	Fri, 4 Dec 2015 10:37:30 -0500
From:	Josef Bacik <jbacik@...com>
To:	<rostedt@...dmis.org>, <kernel-team@...com>,
	<linux-kernel@...r.kernel.org>
Subject: [PATCH] trace-cmd: quiet some output when using libtracecmd

If you link against libtracecmd you get a few extraneous warnings and printf's
that aren't related to your tool.  So by default make the path to the events you
are tracing use pr_stat() so if it's not defined we don't get the output, and
make the weak warning() do nothing by default.  The trace-cmd stuff has this
defined so it'll continue to work normally, it just won't be noisy for consumers
of libtracecmd.  Thanks,

Signed-off-by: Josef Bacik <jbacik@...com>
---
 parse-utils.c  | 5 -----
 trace-record.c | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/parse-utils.c b/parse-utils.c
index c5b0487..9f9c0e9 100644
--- a/parse-utils.c
+++ b/parse-utils.c
@@ -63,11 +63,6 @@ void __warning(const char *fmt, ...)
 
 void __weak warning(const char *fmt, ...)
 {
-	va_list ap;
-
-	va_start(ap, fmt);
-	__vwarning(fmt, ap);
-	va_end(ap);
 }
 
 void __vpr_stat(const char *fmt, va_list ap)
diff --git a/trace-record.c b/trace-record.c
index e4194b5..7d3ea37 100644
--- a/trace-record.c
+++ b/trace-record.c
@@ -2120,7 +2120,7 @@ static int expand_event_files(struct buffer_instance *instance,
 		path = globbuf.gl_pathv[i];
 
 		event = create_event(instance, path, old_event);
-		printf("%s\n", path);
+		pr_stat("%s\n", path);
 
 		len = strlen(path);
 
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/