linux-kernel - Re: [PATCH] ahci: don't use MSI when PCI is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4iooKQKYwFnpd7tg0mis=Y3C-P4z4obrwS7m=4jMN5rvQ@mail.gmail.com>
Date:	Fri, 4 Dec 2015 08:37:05 -0800
From:	Dan Williams <dan.j.williams@...el.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, Tejun Heo <tj@...nel.org>,
	"IDE/ATA development list" <linux-ide@...r.kernel.org>,
	Ricardo Neri <ricardo.neri@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chen-Yu Tsai <wens@...e.org>
Subject: Re: [PATCH] ahci: don't use MSI when PCI is disabled

On Fri, Dec 4, 2015 at 8:34 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Monday 23 November 2015 20:34:30 Arnd Bergmann wrote:
>> On Monday 23 November 2015 09:25:38 Dan Williams wrote:
>> >
>> > If we had an "static inline ahci_irq_vector(int port)"  helper to
>> > compile out the struct msix_entry de-reference would that be
>> > sufficient?
>>
>> Yes, that is probably a nicer way to do it. We should then also do
>> something like this:
>>
>> @@ -2510,7 +2513,8 @@ int ahci_host_activate(struct ata_host *host, struct scsi_host_template *sht)
>>         int irq = hpriv->irq;
>>         int rc;
>>
>> -       if (hpriv->flags & (AHCI_HFLAG_MULTI_MSI | AHCI_HFLAG_MULTI_MSIX))
>> +       if (IS_ENABLED(CONFIG_PCI_MSI) && \
>> +           hpriv->flags & (AHCI_HFLAG_MULTI_MSI | AHCI_HFLAG_MULTI_MSIX))
>>                 rc = ahci_host_activate_multi_irqs(host, sht);
>>         else if (hpriv->flags & AHCI_HFLAG_EDGE_IRQ)
>>                 rc = ata_host_activate(host, irq, ahci_single_edge_irq_intr,
>>
>> which will let gcc leave out the entire ahci_host_activate_multi_irqs()
>> function but still flag compile errors in it even if CONFIG_PCI is
>> disabled.
>>
>
> Dan, are you going to do the ahci_irq_vector patch, or should we use my
> original patch to fix up the build error?

Ah, I was about to ask you the same question.  No worries, I'll send
out a patch with the above approach today.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/